Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating getFeeHistory input type #4529

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Nov 9, 2021

Description

From the issue: #4510
Changing the paramters for getFeeHistory to comply with the spec:
input parameter should be formatted as hex not number
https://playground.open-rpc.org/?schemaUrl=https://raw.githubusercontent.com/ethereum/eth1.0-apis/assembled-spec/openrpc.json&uiSchema%5BappBar%5D%5Bui:splitView%5D=true&uiSchema%5BappBar%5D%5Bui:input%5D=false&uiSchema%5BappBar%5D%5Bui:examplesDropdown%5D=false

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Nov 9, 2021

@coveralls
Copy link

coveralls commented Nov 9, 2021

Pull Request Test Coverage Report for Build 1463257976

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.548%

Totals Coverage Status
Change from base Build 1442485720: 0.0%
Covered Lines: 3359
Relevant Lines: 4372

💛 - Coveralls

@luu-alex luu-alex linked an issue Nov 10, 2021 that may be closed by this pull request
1 task
@luu-alex luu-alex marked this pull request as ready for review November 12, 2021 19:22
CHANGELOG.md Outdated Show resolved Hide resolved
@luu-alex luu-alex requested a review from jdevcs November 15, 2021 17:06
@luu-alex luu-alex added the 1.x 1.0 related issues label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getFeeHistory gives error when running local fork with hardhat
5 participants